CVS history broken (Bugzilla #18952)

[vladak]

status NEW severity trivial in component analyzer for ---
Reported in version unspecified on platform ANY/Generic
Assigned to: Trond Norbye

On 2011-09-20 16:10:28 +0000, Milan Jurik wrote:

http:///source/history/NetBSD-current/usr.bin/ftp/ftp.c

• history is broken with sorting:

[...]
1.3
1.2
1.1
1.1.2.1
1.1.1.2
1.1.1.1
1.9.2.2
1.9.2.1
1.29.2.2
[...]

[swills]

I'm seeing this too, and it happens to be with the NetBSD repo. Is there perhaps something particular about this repo that triggers the issue?

[vladak]

I wouldn't say it's specific to NetBSD CVS repo. The ordering of the revisions as OpenGrok presents them is based directly on the output from cvs log usr.bin/ftp/ftp.c. i.e. the way cvs log command itself sorts the revisions. However, if I use -b (Only list revisions on the default branch) option for cvs log I get the list of revisions in the correct order so maybe we should be using that. However we would then lose the ability to see revisions such as 1.1.2.1 and such. The other option is to have the CVS history log parser sort the revisions.

[vladak]

Checking what cvsweb does (http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/ftp/ftp.c?only_with_tag=MAIN - result of directory browsing, no tag clicking etc.) it displays the results matching cvs log -b src/usr.bin/ftp/ftp.c.

[tarzanek]

We added -b because of some bug request (to see branches)
I also think CVS must die ... @swills any chance NetBSD starts using something more advanced ;) ?
(I am joking, but cvs is really a dead technology ... )

[swills]

@tarzanek are you saying -b is currently used by OpenGrok? If so, I can't find it. And the results in OpenGrok look like the results without -b, I think.

And as far as switching away from CVS, I would be happy with that too. Personally, I'm a FreeBSD user, I'm just indexing the code for comparison. :)

Thanks!

[vladak]

@tarzanek : you actually replaced -b in 3ad4470 with -r <branch>. Maybe we should be using -b if branch is not specified (in getHistoryLogExecutor()), otherwise use -r <branch> or maybe even use -b for both cases.

I think CVS is still good test case for OpenGrok. Anyway, let people use what they think suits them well.

[vladak]

And yes, I have to admit I was probably the one who suggested that -b is replaced with -r <branch> :-P