Comments in git directory history are centered (Bugzilla #19244)

[vladak]

status NEW severity minor in component webapp for ---
Reported in version unspecified on platform i86pc/amd64
Assigned to: Lubos Kosco

On 2012-10-11 21:54:49 +0000, Brian Johnson wrote:

I'm running opengrok 0.11.1 on SLES10 x64, indexing a git tree.

Using the default skin, the text in the "Comments" column of directory
history pages is centered, making it hard to read. However, in file
history displays it is left justified, as expected.

It appears that the "#revisions tbody" elements in the default
style.css don't take into account that directory history has 4
columns, but file history has five. Therefore the Comments column
in a directory history (the fourth column) ends up centered.

On 2012-10-12 06:16:34 +0000, Jens Elkner wrote:

http://defect.opensolaris.org/bz/show_bug.cgi?id=19199 changeset 1423 (see e.g.
http://src.iws.cs.ovgu.de/source/diff/opengrok-jel/web/static/polished/style.css?r1=/opengrok-jel/web/static/polished/style.css@1390:04e4831c7e72&r2=/opengrok-jel/web/static/polished/style.css@1423:488ba30c8520&format=w&full=0
) may help to fix it.

[vladak]

I see that in latest 0.12-rc2. The problem is that the history view for directory has one less column than the history view for a file - the Compare column.

[vladak]

Not sure how to properly fix this - surely duplicating the #revision into one for file and another for directory history would work but this is probably suboptimal. Any CSS experts out there ? Maybe it is possible to split just #revisions tbody ?

[vladak]

Looking at jen's changes, he has introduced new class revh for the <a href= elements in file list and wrapped the comments in <div> or <p> which then are adjusted using stuff like this:

#revisions td > p { /* log message */
  text-align: left;
}

#revisions td > div { /* file list */
  text-align: left;
}

instead of the numbered stuff (td:nth-child) used today.

so that it would look like this:

        <tr>
            <td>41a6c88e</td>
            <td>26-Aug-2013</td>
            <td><a href="http://www.myserver.org/viewProfile.jspa?username=Vladimir.Kotal@Oracle.COM">Vladimir Kotal &lt;Vladimir.Kotal@Oracle.COM&gt;</a></td>
            <td><p>first words of the novel<span class="filelist-hidden"><br/></p>
<a class="revh" href="/source/xref/git-move-around/novel.txt?r=41a6c88e">novel.txt</a><br/></span></td>
        </tr>

[vladak]

The revh is not necessary. The fix for this should also make the list of files (in the comment column, when unhidden) to be left-centered.