Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store latest revision for file based history cache #729

Closed
vladak opened this issue Jan 24, 2014 · 2 comments · Fixed by #766
Closed

store latest revision for file based history cache #729

vladak opened this issue Jan 24, 2014 · 2 comments · Fixed by #766
Assignees
Milestone

Comments

@vladak
Copy link
Member

vladak commented Jan 24, 2014

When debugging fix for issue #728 I discovered (with quite a shock) that last indexed changeset for file based history is not stored (FileHistoryCache.java):

371    @Override
372    public String getLatestCachedRevision(Repository repository) {
373        return null;
374    }

and therefore full history reindex is done every time.

It should be possible to stash the latest indexed changeset for each project somewhere under the data dir.

@vladak
Copy link
Member Author

vladak commented Jan 29, 2014

This should also help @xsumbe00 with his huge Mercurial repository where hg log for the top-level directory takes many hours to complete.

@vladak vladak self-assigned this Feb 27, 2014
@vladak vladak added the stopper label Feb 27, 2014
@vladak
Copy link
Member Author

vladak commented Feb 27, 2014

I am marking this as a stopper since for our internal deployment it is not sure if we can get JavaDB to scale (due to the renamed handling changes done in #13).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants