-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ONNX export support to Tribuo's LinearSGDModels #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row ONNX related methods.
…ode to make it more available to other sgd implementations.
…at test time, this was causing a loop in the build when introducing MultiLabelTransformer in Interop-ONNX.
Interop/ONNX/src/main/java/org/tribuo/interop/onnx/MultiLabelTransformer.java
Outdated
Show resolved
Hide resolved
JackSullivan
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for exporting LinearSGDModels (classification, regression and multi-label) to ONNX format. The ONNX support will grow over the next few PRs as we add support for other Tribuo models, though it's likely that XGBoost and TensorFlow models will require the use of the Python converter packages to emit ONNX format.
This involves several changes:
MultiLabelTransformer
to allow the loading of multi-label ONNX models.AbstractLinearSGDModel
. This might move toAbstractSGDModel
when we add ONNX support to factorization machines.LinearSGDModel
now implementsONNXExportable
which adds methods to create aModelProto
which encapsulates the whole model, aGraphProto
which represents the model computation, and a save method which can write out an ONNX file.As we expand the coverage to ensemble methods the
ONNXExportable
interface might change slightly, and the specific naming of the input and output nodes is likely to change (which might induce some method signature changes). I'd like to land this chunk first though as a single PR for the whole of Tribuo will be far too large to review.One further thing that I'm considering is storing the provenance in a machine readable format inside the ONNX model, and having
ONNXExternalModel
expose that provenance, but I don't want to have everything depend on Jackson and protobuf so the current JSON based provenance string is not ideal.Motivation
We'd like to export Tribuo models for use in other environments, and ONNX is a popular interchange format with a friendly license that we already support model import from.