Adds a ConfigurableDataSource data generator for Clustering #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
changed the title
jhalexand
reviewed
Aug 18, 2021
There was a problem hiding this comment.
The description for "mixingPMF" (and/or the name) could probably be a little clearer and updated both in the @Config variable's description and in the constructor.
It occurs to me that we should be checking that the variances are positive numbers both because variances are usually expressed as positive numbers and, of course, because we take the sqrt of them.
|
It also occurs to me that the same issue, re: variances, exists in GaussianAnomolyDataSource and could be updated along with this PR. |
|
Sure, I'll fix those. |
Craigacp
force-pushed
the
cluster-data-source
branch
from
f803a68 to
991061f
Compare
|
I've updated the PR with your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a configurable data source for clustering demos and testing. Updated the clustering tutorial to use it.
The timing numbers are from my M1 Mac which is so fast that the multithreaded one takes roughly the same time as the single threaded one rather than being 3x faster (though it is running on 4x the data).
Motivation
See #160 for the motivation.