Two small fixes for provenance. #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
added
Oracle employee
pogren
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
New constructor on ExternalTrainerProvenance takes a byte array and manages to create a working provenance using the hash value generated from the byte array, the current time, and the current working directory. This is used by XGBoostExternalModel.createXGBoostModel so that the provenance works. Also, some care has been given to synchronize the training and provenance construction in TransformTrainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches around how the provenance is captured in TransformTrainer so it has the right values, and updates XGBoostExternalModel so there is a way to create a model from an in-memory XGBoost
Booster, which required an extra constructor onExternalTrainerProvenance.Motivation
The transform trainer was capturing the incorrect state of the inner trainer's RNG, and the XGBoost external model creator would always throw an exception if you didn't have a valid URL to a path on disk that it could hash.