Adding some accessors to allow deeper model equality checks #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed a bug in LibLinearRegressionModel.getTopFeatures where it tried to lookup the bias.
Craigacp
added
Oracle employee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added accessors for TreeModel to get the root node(s) so they can be compared for equality using their equals implementations. Added an equality method for two
svm_models as there isn't one onsvm_model. Also fixed a bug in LibLinearRegressionModel.getTopFeatures where it tried to lookup the bias and threw an exception.Motivation
We use the expanded model equality checks when testing the reproducibility work.