Reproducibility generics cleanup #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
added
Oracle employee
JackSullivan
reviewed
Nov 3, 2021
Reproducibility/src/main/java/org/tribuo/reproducibility/ReproUtil.java
Outdated
Show resolved
Hide resolved
JackSullivan
reviewed
Nov 3, 2021
Reproducibility/src/main/java/org/tribuo/reproducibility/ReproUtil.java
Outdated
Show resolved
Hide resolved
JackSullivan
requested changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up the generics in the reproducibility so it compiles without warnings. It adds an output type to the
ReproUtilas the target type inference used previously could infer the incorrect type from the calling environment.Also added support for extracting the provenance from an
ONNXExternalModelif it contains a Tribuo provenance field in the ONNX model.Motivation
Compiler warnings are bad.