Adds setInvocationCount to HdbscanTrainer #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tics of Trainer.train(Dataset<T>, Map<String,Provenance>, int) by allowing negative -1 as an argument.
Craigacp
added
Oracle employee
Clustering/Hdbscan/src/main/java/org/tribuo/clustering/hdbscan/HdbscanTrainer.java
Show resolved
Hide resolved
pogren
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
setInvocationCountmethod toHdbscanTrainerand tidies up a couple of small things in the HDBSCAN package.It also enforces that the default method
Trainer.train(Dataset<T>,Map<String,Provenance>,int)accepts -1 to mean "do not change the invocation count before training" which is the implied semantics forINCREMENT_INVOCATION_COUNT.Motivation
Improves integration with the reproducibility framework.