Moving ONNX export utils out into a separate module #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
added
Oracle employee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the
org.tribuo.onnxclasses fromtribuo-coretotribuo-util-onnx, which has no dependencies on the rest of Tribuo. Then movedONNXExportabletoorg.tribuo, and moved the model proto construction method toONNXExportablefromONNXContext.Motivation
Splitting out the core ONNX model writing code into a separate jar will make it possible for the rest of the JVM ecosystem to use it to build out ONNX model support without inducing a Tribuo dependency. This will make it easier if we decide to upstream that support later, and will hopefully encourage contributions to fill out the support with the rest of the ONNX operators.