Bumping to liblinear-java 2.44 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and removing the global liblinear locks in Tribuo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
liblinear-java 2.44 has the fix for bwaldvogel/liblinear-java#40, and so this PR migrates Tribuo over to use the new RNG setting methods available in that version. As a consequence it removes all the global locks on liblinear use that were in place from 4.2. This does mean that models trained in 4.2 will not reproduce exactly in 4.3+, though we could consider moving the
forceZerotrick used in the regression tests into the base class and exposing it to the reproducibility framework as a special case.Motivation
Allows liblinear models to be trained in parallel with consistent RNG behaviour as compared to the rest of Tribuo.