Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelcard tutorial #253

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Modelcard tutorial #253

merged 3 commits into from
Jul 26, 2022

Conversation

rmahinpei
Copy link
Contributor

Description

Creating a tutorial to highlight the features of the ModelCard system.

Signed-off-by: Romina Mahinpei <mahinpei@student.ubc.ca>
Signed-off-by: Romina Mahinpei <mahinpei@student.ubc.ca>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 23, 2022
@Craigacp
Copy link
Member

Can you add a link to the model card tutorial in the README.md inside the tutorials folder?

Copy link
Member

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several small things. Could you run a full spell check pass on the notebook, I think I caught all the typos but I'm not sure I did.

tutorials/modelcard-tribuo-v4.ipynb Outdated Show resolved Hide resolved
Interop/ModelCard/pom.xml Outdated Show resolved Hide resolved
tutorials/modelcard-tribuo-v4.ipynb Outdated Show resolved Hide resolved
tutorials/modelcard-tribuo-v4.ipynb Outdated Show resolved Hide resolved
tutorials/modelcard-tribuo-v4.ipynb Outdated Show resolved Hide resolved
tutorials/modelcard-tribuo-v4.ipynb Outdated Show resolved Hide resolved
Signed-off-by: Romina Mahinpei <mahinpei@student.ubc.ca>
@rmahinpei
Copy link
Contributor Author

Thank you for the feedback! I've addressed them all and also ran a full spell check on the notebook.

Copy link
Member

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all your hard work Romina!

@Craigacp Craigacp merged commit 47a5566 into oracle:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants