Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SLM protobuf serialization #269

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Adding SLM protobuf serialization #269

merged 1 commit into from
Sep 13, 2022

Conversation

Craigacp
Copy link
Member

@Craigacp Craigacp commented Sep 9, 2022

Description

Adds protobuf serialization support to sparse linear models.

Motivation

We need to move off Java serialization.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 9, 2022
pogren
pogren approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@pogren pogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward proto serialization code is tested with reasonable code coverage.

@Craigacp Craigacp merged commit af1db52 into main Sep 13, 2022
@Craigacp Craigacp deleted the slm-proto branch September 13, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pogren pogren pogren approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Craigacp @pogren