Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds protobuf serialization for OCI, ONNX and TF models #271

Merged
merged 7 commits into from
Sep 19, 2022
Merged

Adds protobuf serialization for OCI, ONNX and TF models #271

merged 7 commits into from
Sep 19, 2022

Conversation

Craigacp
Copy link
Member

@Craigacp Craigacp commented Sep 9, 2022

Description

Adds protobuf serialization to external models, and also some equals methods with thresholds for comparing Output and Prediction.

Motivation

We need to move off Java serialization.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 9, 2022
@Craigacp Craigacp added the squash-commits Squash the commits when merging this PR label Sep 9, 2022
pogren
pogren approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@pogren pogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward protobuf serialization code plus a few 'fullEquals' and 'distributionEquals' methods which take a threshold parameter

@Craigacp Craigacp merged commit 5468573 into main Sep 19, 2022
@Craigacp Craigacp deleted the external-proto branch September 19, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pogren pogren pogren approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. squash-commits Squash the commits when merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Craigacp @pogren