Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds clustering & nearest neighbour protobuf serialization #276

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

Craigacp
Copy link
Member

@Craigacp Craigacp commented Sep 12, 2022

Description

Adds protobuf serialization to HDBSCAN, K-Means, K-NN, and weighted ensemble models.

Motivation

We need to move off Java serialization.

@Craigacp Craigacp added the squash-commits Squash the commits when merging this PR label Sep 12, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 12, 2022
Copy link
Member

@pogren pogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me overall. My only nit to pick here is that it doesn't seem like WeightedEnsembleModel.serialize and deserializeFromProto are tested.

@Craigacp
Copy link
Member Author

Yeah, at the moment they aren't because I want to test them using a variety of models as the ensemble members and when this PR was made only the multinomial naive Bayes model was ProtoSerializable. It's on the to-do list once all the other PRs have landed.

@Craigacp Craigacp merged commit 65678fb into main Sep 22, 2022
@Craigacp Craigacp deleted the clustering-serialization branch September 22, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. squash-commits Squash the commits when merging this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants