Adds protobuf serialization to Tree models #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
pogren
previously approved these changes
Oct 3, 2022
Craigacp
force-pushed
the
tree-serialization
branch
from
d84a46b to
8734bc2
Compare
Fix typo
pogren
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds protobuf serialization to Tribuo's tree models. Unlike the other protobuf models this requires some complex logic to linearise the tree rather than arbitrarily nesting the protobufs. This is because in the future we will want to store the tree linearly anyway as it's much more cache efficient, and so having the storage format line up with that will make the internal transformation much simpler.
Motivation
We need to move off Java serialization.