Migrates DistanceType to a Distance interface
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@Craigacp This is a great improvement without breaking compatibility. Nice. |
|
Well done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
Distanceinterface inorg.tribuo.math.distance, along with implementations for Cosine, L1 and L2. Users can supply their own distance computation function by implementing the interface. All models which were previously migrated to useDistanceTypenow store aDistanceinstance, and the enum holds a singleton of each of the built in types for easy use in CLI programs and as default arguments.cc @geoffreydstewart
Motivation
The set of available distances was too limiting, fixes #284.