Improving the multiple response documentation in CSVLoader #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test for the documented behaviour and fixing a small toString bug in MockMultiOutput and MultiLabel.
oracle-contributor-agreement
bot
added
the
OCA Verified
Craigacp
added a commit
that referenced
this pull request
Dec 16, 2022
…test for the documented behaviour and fixing a small toString bug in MockMultiOutput and MultiLabel. (#306)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more javadoc for the explicit behaviour of
CSVLoaderin multi-output datasets. Fixes a small bug in thetoStringmethod ofMockMultiOutputandMultiLabelwhich caused poorly formatted strings when the label set was empty. Also adds an extra test for the multioutput behaviour ofCSVLoaderto ensure it matches the documentation.It may be worth adding a similar documentation note to
FieldResponseProcessoras that actually does the processing.Motivation
CSVLoaderis poorly documented when processing multiple output columns. Fixes #301.