Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an empty response processor that always returns an empty optional #99

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

Craigacp
Copy link
Member

@Craigacp Craigacp commented Nov 27, 2020

Description

Adds a response processor which always returns an empty optional (i.e. no response). This is used by RowProcessors which operate on unlabelled data like clustering or anomaly detection tasks.

Also adds an additional constructor to RowProcessor to make it a little simpler to use.

Motivation

Makes like simpler when loading clustering or anomaly detection columnar datasets.

Partial fix for #72.

Copy link
Member

@jhalexand jhalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jhalexand jhalexand merged commit 56bb558 into main Nov 30, 2020
@jhalexand jhalexand deleted the null-response-processor branch November 30, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants