Make use of modern-style quotes #197
Conversation
(See issue orakaro#134) Twitter introduced a new way of quoting, by simply putting the tweet url as a quote. The web interface (and most clients) will then display a preview of the quoted tweet, leaving more characters available for your quote. This patch change the default quote format from the old mode ("#comment RT #owner #text") to the new one, introducing a new #tid keyword holding the tweet id (needed to find the tweet URL). It's still possible to go back to the old mode, by changing the QUOTE_FORMAT config parameter back to "#comment RT @#owner #text".
| screen_name = str( tweet['user']['screen_name'] ) | ||
| text = str( tweet['text'] ) | ||
| tid = str( tweet['id'] ) | ||
|
|
There was a problem hiding this comment.
str function is not compatible with Python 2 unicode type, in case text is non-English character (ex: Japanese).
There was a problem hiding this comment.
Oops, sorry about that. The str() functions for screen_name and text are not really needed, since these values are already printable as is. For tid however, I should keep the str() since tweet['id'] is an integer.
| @@ -24,7 +24,7 @@ | |||
| // 'conversation': max tweet in a thread | |||
| "CONVERSATION_MAX" : 30, | |||
| // 'quote' format | |||
| "QUOTE_FORMAT" : "#comment RT #owner: #tweet", | |||
| "QUOTE_FORMAT" : "#comment https:\/\/twitter.com\/#owner\/status\/#tid", | |||
There was a problem hiding this comment.
One thing to note: even if we change value here it will not affect already installed user. I preserved their customized config file every update time. This can only help new users.
There was a problem hiding this comment.
Yes, but already installed users will still be able to change their configuration if they want to use this feature (like I did).
To avoid messing up unicode non-latin characters. This was a requested change.
During the config parse, comments are removed using a complex regexp, matching (among other things) '//'. A problem arises when your configuration contains a link of some sort (such as 'http://' ...). The regexp then consider the '//' and what follows as a comment (and your configuration is consequently considered corrupt). Escapinf the '/' works for a time, but it fails as soon as you use the 'config' command at runtime, because the configuration is then rewritten. Therefore I changed the regexp used to match comments. It's a fairly complex regexp though, and I'm not 100% positive my change is perfect. Fell free to review it.
|
I did the change you requested in dd4ac7c. I also corrected a small bug: after using the 'config' command, there was an error when parsing my configuration. The escaped string 'http://...' was rewritten unescaped as 'http://...' and the '//...' part was wrongly parsed as a comment. I put all details in 6bb36e2 commit message. |
There was a problem hiding this comment.
Thanks.
Actually i excluded QUOTE_FORMAT (along with 4 other config key) before showing user in the console in https://github.com/DTVD/rainbowstream/blob/master/rainbowstream/config.py#L48 so people are unlikely to use config command to set QUOTE_FORMAT as described.
Although fixing the regex has the downside that we no longer can read comment inside of any line, I agree that it helps setting format easier.
This will be merged in this weekend.
(See issue #134)
Twitter introduced a new way of quoting, by simply putting the tweet url
as a quote. The web interface (and most clients) will then display a
preview of the quoted tweet, leaving more characters available for your
quote.
This patch change the default quote format from the old mode ("#comment
RT #owner #text") to the new one, introducing a new #tid keyword holding
the tweet id (needed to find the tweet URL). It's still possible to go
back to the old mode, by changing the QUOTE_FORMAT config parameter
back to "#comment RT @#owner #text".