Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Add credhub exporter #6

Merged
merged 8 commits into from
Aug 22, 2018
Merged

[INTERNAL] Add credhub exporter #6

merged 8 commits into from
Aug 22, 2018

Conversation

psycofdj
Copy link
Member

@psycofdj psycofdj commented Aug 20, 2018

This is an Orange internal PR to prepare an upsteam PR to bosh-prometheus/prometheus-boshrelease.

The text below aims at being included in the upstream PR


This PR integrates a new exporter for monitoring some content of a credhub server, specifically creation dates of credentials and expiration of certificates (it does not yet provide metrics about the credhub server health such as error rates, response times, or total number of entries).

This PR includes an associated dashboard and alerts that triggers when certificates are close to expiration.

We'd be happy to transfer ownership of the orange-cloudfoundry/credhub_exporter to the https://github.com/bosh-prometheus/ organization if this makes more sense for the community to contribute maintenance.

Relates to https://github.com/orange-cloudfoundry/paas-templates/issues/84

@gberche-orange
Copy link
Member

gberche-orange commented Aug 20, 2018

@psycofdj some feedback on the https://github.com/orange-cloudfoundry/credhub_exporter submitted as github issues:

orange-cloudfoundry/credhub_exporter#5 Keep deployment-name flag instead of director label
orange-cloudfoundry/credhub_exporter#6 Support for specifying credhub root path or creds name matching query string

Copy link
Member

@gberche-orange gberche-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @psycofdj Please review related wording PR at #7

@gberche-orange
Copy link
Member

@psycofdj LGTM, feel free to submit the PR upstream.

@psycofdj psycofdj merged commit 3f9022e into master Aug 22, 2018
@gberche-orange
Copy link
Member

Upstream PR: cloudfoundry#241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants