Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples for the auth module #182

Merged
merged 10 commits into from
Jun 29, 2022
Merged

examples for the auth module #182

merged 10 commits into from
Jun 29, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Jun 16, 2022 •
edited
Loading

Completes and resolves #60

Resolves #149

Examples of using the http client.

qweeah
qweeah suggested changes Jun 17, 2022
View reviewed changes
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
Wwwsylvia
Wwwsylvia reviewed Jun 20, 2022
View reviewed changes
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT mentioned this pull request Jun 23, 2022
Closed
9 tasks
shizhMSFT
shizhMSFT reviewed Jun 23, 2022
View reviewed changes
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

Should we also add an "Authentication examples" entry in the README?

@shizhMSFT
Copy link
Contributor

Should we also add an "Authentication examples" entry in the README?

Yes, definitely.

shizhMSFT
shizhMSFT reviewed Jun 27, 2022
View reviewed changes
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
@wangxiaoxuan273
Copy link
Contributor Author

I'll add an extra example on refresh token in another pr.

@Wwwsylvia Wwwsylvia mentioned this pull request Jun 28, 2022
Closed
@wangxiaoxuan273
some progress but the server can't work because of Do implementation
793f483 
added 4 examples of the client

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
made changes according to comments
19f6220 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
addressed the comments
f184e26 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
improved the credential function
800ca06 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
addressed the comments
c762644 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
addressed Shiwei's comments
06ae931 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
checked and improved global variables
dc2ec47 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
wangxiaoxuan273
wangxiaoxuan273 commented Jun 29, 2022
View reviewed changes
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
@wangxiaoxuan273
rewrote the comments about scopes
0f5c57b 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
put true to OAuth
7d5f30f 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
changed URL comments
7822743 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
shizhMSFT
shizhMSFT approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 3f83f0c into oras-project:main Jun 29, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the auth-example branch June 29, 2022 06:14
@Wwwsylvia
Copy link
Member

Should we also add an "Authentication examples" entry in the README?

Related issue: #215

@wangxiaoxuan273 wangxiaoxuan273 mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Wwwsylvia Wwwsylvia Awaiting requested review from Wwwsylvia Wwwsylvia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add examples for the auth package Update Example
4 participants
@wangxiaoxuan273 @Wwwsylvia @shizhMSFT @qweeah