Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter referrers by artifact type #211

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Conversation

m5i-work
Copy link
Contributor

@m5i-work m5i-work commented Jun 28, 2022

Resolves #140

Tested against oras-distribution and ACR DF3

Signed-off-by: Wei Meng wemeng@microsoft.com

@m5i-work
Copy link
Contributor Author

@shizhMSFT @Wwwsylvia Please help review, thanks!

registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/repository_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

registry/remote/url.go Show resolved Hide resolved
registry/remote/url.go Show resolved Hide resolved
registry/remote/repository.go Outdated Show resolved Hide resolved
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

registry/remote/url.go Show resolved Hide resolved
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Signed-off-by: Wei Meng <wemeng@microsoft.com>
j++
}
}
return refs[:j]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool in-place filtering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement aritfactType filtering
4 participants