Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/pre commit updates #102

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

dev-zero
Copy link
Contributor

  • fix pre-commit config and typings
  • tests: move registry infos to fixtures

@dev-zero
Copy link
Contributor Author

Interesting, make test succeeds here. Any ideas @vsoch ?
Also, do you want a change like this?

@vsoch
Copy link
Contributor

vsoch commented Jul 26, 2023

Interesting, make test succeeds here. Any ideas @vsoch ?

Sorry, are you asking why the CI auth tests are failing? It looks like it's trying to use localhost and port 80.

I'm always up for improvements in the linting and CI, so if you get something working that is an improvement I support that.

@dev-zero dev-zero force-pushed the feature/pre-commit-updates branch 3 times, most recently from 765d0a9 to 09f2f23 Compare September 27, 2023 13:57
Signed-off-by: Tiziano Müller <tiziano.mueller@hpe.com>
Signed-off-by: Tiziano Müller <tiziano.mueller@hpe.com>
Signed-off-by: Tiziano Müller <tiziano.mueller@hpe.com>
@dev-zero dev-zero marked this pull request as ready for review September 27, 2023 14:05
@dev-zero
Copy link
Contributor Author

@vsoch ready for review

Note, the easiest way to handle pre-commit is to use the pre-commit bot from https://pre-commit.ci/
It will get you 2 things mainly:

  • periodic checks with PRs on outdated pre-commit dependencies
  • automated pre-commit checks on PRs with automatically added commits to fix violations (if possible), ideal for one-off PRs where you can easily squash the commits

Copy link
Contributor

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making these changes!

@vsoch vsoch merged commit 07272ea into oras-project:main Sep 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants