Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 90 - empty manifest config support on Windows #91

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

sunnycarter
Copy link
Contributor

@sunnycarter sunnycarter commented Jul 4, 2023

Fix for #90

Tested with repro on Windows and Linux.

I'm not quite sure what to do with the CHANGELOG.md I'm afraid so please give guidance.

oras/oci.py Outdated Show resolved Hide resolved
oras/provider.py Outdated Show resolved Hide resolved
@sunnycarter
Copy link
Contributor Author

Thanks for the review, the nod to write a utility function led me to discover there's an inbuilt one

@vsoch
Copy link
Contributor

vsoch commented Jul 4, 2023

Thanks for the review, the nod to write a utility function led me to discover there's an inbuilt one

Nice! And good intuition to look for that too!

For the DCO you can click on "Details" to learn more about that - if I remember it's just an electronic page you need to agree to and then you are good. It would only be done once! The ORAS family of projects is under the CNCF umbrella so we follow these policies that are enforced there.

@vsoch
Copy link
Contributor

vsoch commented Jul 4, 2023

I'm not quite sure what to do with the CHANGELOG.md I'm afraid so please give guidance.

For this, you'll want to increment the version to 0.1.18 here:

__version__ = "0.1.17"

And then make a note (with that corresponding version) on a newline above 0.1.17 here https://github.com/oras-project/oras-py/blob/main/CHANGELOG.md

Signed-off-by: Sunny Carter <sunny.carter@metaswitch.com>
Signed-off-by: Sunny Carter <sunny.carter@metaswitch.com>
Signed-off-by: Sunny Carter <sunny.carter@metaswitch.com>
@sunnycarter
Copy link
Contributor Author

Thanks for looking at this, I've now signed all commits to fulfil the DCO, and pushed a new commit with a patch version bump and changelog update.

@vsoch vsoch merged commit 622201d into oras-project:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants