-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 90 - empty manifest config support on Windows #91
Conversation
Thanks for the review, the nod to write a utility function led me to discover there's an inbuilt one |
Nice! And good intuition to look for that too! For the DCO you can click on "Details" to learn more about that - if I remember it's just an electronic page you need to agree to and then you are good. It would only be done once! The ORAS family of projects is under the CNCF umbrella so we follow these policies that are enforced there. |
For this, you'll want to increment the version to 0.1.18 here: Line 5 in 209c9b9
And then make a note (with that corresponding version) on a newline above 0.1.17 here https://github.com/oras-project/oras-py/blob/main/CHANGELOG.md |
Signed-off-by: Sunny Carter <sunny.carter@metaswitch.com>
Signed-off-by: Sunny Carter <sunny.carter@metaswitch.com>
fc50756
to
543343b
Compare
Signed-off-by: Sunny Carter <sunny.carter@metaswitch.com>
Thanks for looking at this, I've now signed all commits to fulfil the DCO, and pushed a new commit with a patch version bump and changelog update. |
Fix for #90
Tested with repro on Windows and Linux.
I'm not quite sure what to do with the CHANGELOG.md I'm afraid so please give guidance.