Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exempt stale if milestone is set #1036

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jul 24, 2023

This PR adds a workflow change which will avoid marking PRs or issues as stale if any milestone is tagged.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #1036 (393a62c) into main (0b6651a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          57       57           
  Lines        2912     2912           
=======================================
  Hits         2366     2366           
  Misses        373      373           
  Partials      173      173           

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sajayantony
Copy link
Contributor

Thanks for the change @qweeah - This also means we should review the milestones regularly so that issues don't get stale in there. Honestly I'm happy that a lot of old issues got bumped and makes the maintainers consider if we actually will ever get to it.

Future seems like a backlog milestone, should we avoid moving everything to future unless there is plan and/or close them off since there is no immediate plan would be a question for us to agree on.

@qweeah qweeah merged commit e6b9a44 into oras-project:main Jul 27, 2023
6 checks passed
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah deleted the chore/exempt-milestone branch August 25, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants