Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support warning in remote targets #1057

Merged
merged 56 commits into from
Aug 23, 2023
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 9, 2023

What this PR does / why we need it:
Fixes #898

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah changed the title feat: pack OCI image spec v1.1 manifests feat: support warning in remote targets Aug 9, 2023
@qweeah qweeah marked this pull request as draft August 9, 2023 01:34
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #1057 (9a9b387) into main (742b044) will decrease coverage by 0.02%.
The diff coverage is 89.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   80.00%   79.99%   -0.02%     
==========================================
  Files          56       56              
  Lines        2896     2914      +18     
==========================================
+ Hits         2317     2331      +14     
- Misses        402      405       +3     
- Partials      177      178       +1     
Files Changed Coverage Δ
cmd/oras/internal/option/remote.go 77.38% <76.00%> (-0.21%) ⬇️
cmd/oras/root/discover.go 84.72% <85.71%> (ø)
cmd/oras/internal/option/target.go 84.69% <100.00%> (+0.31%) ⬆️
cmd/oras/root/attach.go 81.89% <100.00%> (ø)
cmd/oras/root/blob/delete.go 82.60% <100.00%> (ø)
cmd/oras/root/blob/fetch.go 68.26% <100.00%> (ø)
cmd/oras/root/blob/push.go 83.69% <100.00%> (ø)
cmd/oras/root/cp.go 86.56% <100.00%> (ø)
cmd/oras/root/login.go 72.22% <100.00%> (ø)
cmd/oras/root/manifest/delete.go 82.19% <100.00%> (ø)
... and 8 more

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Copy link
Contributor Author

qweeah commented Aug 22, 2023

@Wwwsylvia test fixed, can you help review again.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am not a maintainer

cmd/oras/root/discover.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should ImageSpec.PackType be changed to ImageSpec.PackVersion?

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe
Copy link
Member

Hmm, @Wwwsylvia has a comment

@qweeah
Copy link
Contributor Author

qweeah commented Aug 23, 2023

Should ImageSpec.PackType be changed to ImageSpec.PackVersion?

Good catch. This is not related to change here, I will do in another PR.

@qweeah qweeah merged commit 6319416 into oras-project:main Aug 23, 2023
6 checks passed
@qweeah qweeah deleted the warning branch August 23, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show distribution warning headers as output on the ORAS CLI
5 participants