Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make --debug imply --no-tty #1162

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 2, 2023

What this PR does / why we need it:
This PR makes --debug flag imply --no-tty flag.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #940

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah changed the title feat: make --debug implies --no-tty feat: make --debug imply --no-tty Nov 2, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #1162 (512e36b) into main (5d95881) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   79.93%   79.88%   -0.06%     
==========================================
  Files          65       65              
  Lines        3519     3520       +1     
==========================================
- Hits         2813     2812       -1     
- Misses        492      494       +2     
  Partials      214      214              
Files Coverage Δ
cmd/oras/internal/option/common.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit b911ad6 into oras-project:main Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants