Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: atomic bool for layer skipped during pulling #1168

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 3, 2023

What this PR does / why we need it:
This PR avoids potential race condition when concurrently pulling an image.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #1168 (4fd2453) into main (24ac0c5) will not change coverage.
The diff coverage is 75.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files          65       65           
  Lines        3551     3551           
=======================================
  Hits         2842     2842           
  Misses        494      494           
  Partials      215      215           
Files Coverage Δ
cmd/oras/root/pull.go 74.43% <75.00%> (ø)

@TerryHowe
Copy link
Member

conflicts

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qweeah Please resolve conflicts

cmd/oras/root/pull.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Copy link
Contributor Author

qweeah commented Nov 6, 2023

@TerryHowe @shizhMSFT Thanks for reviewing. Conflict & comments resolved.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit c7c7c3d into oras-project:main Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants