Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(spec): formatted ORAS CLI output #1199

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

FeynmanZhou
Copy link
Member

What this PR does / why we need it:

add spec: Formatted ORAS CLI output

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #638

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (c179d0a) to head (6f5465f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1199   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         107      107           
  Lines        3739     3739           
=======================================
  Hits         3177     3177           
  Misses        334      334           
  Partials      228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FeynmanZhou FeynmanZhou marked this pull request as ready for review December 5, 2023 14:41
@qweeah qweeah changed the title add spec: Formatted ORAS CLI output doc(spec): formatted ORAS CLI output Dec 6, 2023
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT changed the title doc(spec): formatted ORAS CLI output docs(spec): formatted ORAS CLI output Dec 8, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FeynmanZhou Could you also fix the DCO issue?

docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sajayantony sajayantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking approve. Recommend addressing remaining comments from @shizhMSFT

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions on phrasing.

docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/proposals/formatted-output.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit fd38272 into oras-project:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oras commands like attach, discover, and pull support an option to format output as JSON
9 participants