Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add preview feature mark to platform-specific attaching #1337

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Apr 11, 2024

What this PR does / why we need it:
As a complement of #1309, this PR adds preview feature mark to allow future changes on the flag.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (cc9b2b6) to head (9faf443).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files         101      101           
  Lines        3615     3615           
=======================================
  Hits         3051     3051           
  Misses        335      335           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qweeah qweeah merged commit 91268a2 into oras-project:main Apr 12, 2024
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants