docs: add GAR #184
docs: add GAR #184
Conversation
|
|
|
cc @jonjohnsonjr - does this look good for merge? |
|
Content LGTM, but do you mind waiting a until tomorrow to merge? My fix still hasn't rolled out to a couple regions, so I don't want to claim support quite yet. Thanks Hideto! |
|
|
||
| ```sh | ||
| oras push ${REGION}-docker.pkg.dev/${GCP_PROJECT}/samples/artifact:1.0 \ | ||
| ./artifact.txt:application/vnd.unknown.layer.v1+txt |
There was a problem hiding this comment.
@jonjohnsonjr @jdolitsky
Google Artifact Registry does not support config as /dev/null, right?
I tested json, yaml and plain text, thease worked.
Should I add a comment for that specification?
$ oras push ${REGION}-docker.pkg.dev/${GCP_PROJECT}/samples/artifact:1.1 \
> --manifest-config /dev/null:application/vnd.unknown.config.v1+json \
> ./artifact.txt:application/vnd.unknown.layer.v1+txt
Uploading fe1c9c56450d artifact.txt
Error: failed commit on ref "unknown-sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855": unexpected status: 400 Bad Request
There was a problem hiding this comment.
https://github.com/deislabs/oras/blob/v0.8.1/docs/config.md#manifest-config
According to OCI Image Manifest Specification, the property config is required by an image manifest.
There was a problem hiding this comment.
This REQUIRED property references a configuration object for a container, by digest. Beyond the descriptor requirements, ...
From the descriptor requirements:
The following fields contain the primary properties that constitute a Descriptor:
mediaType string
This REQUIRED property contains the media type of the referenced content. Values MUST comply with RFC 6838, including the naming requirements in its section 4.2.
The OCI image specification defines several of its own MIME types for resources defined in the specification.
digest string
This REQUIRED property is the digest of the targeted content, conforming to the requirements outlined in Digests. Retrieved content SHOULD be verified against this digest when consumed via untrusted sources.
size int64
This REQUIRED property specifies the size, in bytes, of the raw content. This property exists so that a client will have an expected size for the content before processing. If the length of the retrieved content does not match the specified length, the content SHOULD NOT be trusted.
As such, this section of the oras description seems to be out of compliance with the spec, from my reading:
Since oras does not make use of the configuration object, an empty JSON object {} is used by default when pushing, and never being fetched when pulling.
This should be good to go now. |
Adds a reference to GAR support.
Closes #157