Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pkg/auth/docker test #204

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Fix pkg/auth/docker test #204

merged 2 commits into from
Dec 14, 2020

Conversation

shizhMSFT
Copy link
Contributor

Fix build failure due to errors in pkg/auth/docker/client_test.go. The root cause is that the test registry may not be running before any test cases.

jdolitsky
jdolitsky approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jdolitsky jdolitsky merged commit d3683ca into main Dec 14, 2020
@shizhMSFT shizhMSFT deleted the shizh/fix_docker_test branch December 18, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shizhMSFT @jdolitsky