use function instead of static map #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
switch-multi-to-func
branch
2 times, most recently
from
70d7d07
to
c66f4c4
Compare
deitch
changed the title
|
Removed |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
switch-multi-to-func
branch
from
c66f4c4
to
76a5d13
Compare
|
And added a test for the new PassthroughMultiWriter |
|
Fully ready for a review @jdolitsky |
jdolitsky
approved these changes
Feb 17, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiwriter passed a
map[string]content.Writer. The problem is that the thing that creates these writers sometimes doesn't know what writer it will use until later. This changes it to a func, so that it can determine it on the fly. The net result is the same, with some more flexibility.Discussed on slack with @jdolitsky
I still have some work to do to be sure this is ready, but the initial view can get looked at.