Updated oras to use updated containerd with artifacts-spec v1 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
shizhMSFT
approved these changes
Sep 6, 2021
| @@ -19,15 +18,16 @@ require ( | |||
| github.com/docker/docker-credential-helpers v0.6.3 // indirect | |||
| github.com/docker/go-connections v0.4.0 // indirect | |||
| github.com/morikuni/aec v1.0.0 // indirect | |||
| github.com/opencontainers/artifacts v0.0.0-20210209205009-a282023000bd | |||
| github.com/opencontainers/artifacts v0.0.0-20210209205009-a282023000bd // indirect | |||
There was a problem hiding this comment.
We can remove this line as github.com/opencontainers/artifacts is used nowhere.
| @@ -386,6 +386,7 @@ github.com/onsi/gomega v0.0.0-20151007035656-2152b45fa28a/go.mod h1:C1qb7wdrVGGV | |||
| github.com/onsi/gomega v0.0.0-20170829124025-dcabb60a477c/go.mod h1:C1qb7wdrVGGVU+Z6iS04AVkA3Q65CEZX59MT0QO5uiA= | |||
| github.com/onsi/gomega v1.7.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= | |||
| github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY= | |||
| github.com/opencontainers/artifacts v0.0.0-20210209205009-a282023000bd/go.mod h1:SD8DjsrkV/11lBKhbcjodFNeLmkZVCvDYPoXKZeGH5Q= | |||
There was a problem hiding this comment.
need to run go mod tidy to clean up go.sum.
| } | ||
| return descs, nil | ||
| return desc, nil | ||
|
|
sajayantony
added a commit
to sajayantony/oras
that referenced
this pull request
Sep 13, 2021
…roject#305) Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sajay Antony sajaya@microsoft.com