Fix permission issue on PUT artifact manifest #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
sajayantony
approved these changes
Oct 28, 2021
shizhMSFT
changed the title
shizhMSFT
changed the title
sajayantony
approved these changes
Oct 28, 2021
sajayantony
approved these changes
Oct 28, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifact manifests failed to PUT with the following error message:
The reason is that incorrect access token is used by the customized
containerdimplementation, and it tries to re-read the request body for new requests. Since piped I/O cannot be rewinded, the PUT fails.Even if the request body is rewindable, the Authorizator reuses the old token with insufficient scope, which does not match the requested scope in the returned challenge of the 401 response.
This PR constructs a proper scope before doing any requests. The implementation follows the
containerdimplementation.