Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy options in push and pull commands #400

Merged
merged 75 commits into from
Jun 21, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jun 2, 2022

This PR refactors pull and push commands with copy options

Resolves #325, resolves #217

qweeah added 30 commits May 16, 2022 22:48
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
go.mod Outdated Show resolved Hide resolved
qweeah added 13 commits June 2, 2022 17:28
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah changed the title [WIP] Use copy options in push command Use copy options in push and pull commands Jun 15, 2022
@qweeah qweeah marked this pull request as ready for review June 15, 2022 16:07
Signed-off-by: Billy Zha <qweeah@gmail.com>
@qweeah qweeah requested a review from shizhMSFT June 16, 2022 05:45
cmd/oras/internal/output/convert.go Outdated Show resolved Hide resolved
cmd/oras/internal/output/convert.go Outdated Show resolved Hide resolved
cmd/oras/internal/output/status.go Outdated Show resolved Hide resolved
internal/status/pull.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
cmd/oras/push.go Outdated Show resolved Hide resolved
cmd/oras/push.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
@qweeah
Copy link
Contributor Author

qweeah commented Jun 21, 2022

If a manifest config is not expected to be pulled, target storage fetch operation should skip the corresponding node copy.

This change is expected to be provided by oras-go, temporarily removing the --manifest-config option from the CLI and will recover it after the skipped copy is supported, see #409

@qweeah qweeah requested a review from shizhMSFT June 21, 2022 07:02
Signed-off-by: Billy Zha <qweeah@gmail.com>
@qweeah qweeah requested a review from shizhMSFT June 21, 2022 09:27
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 4eabef7 into oras-project:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants