feat: add copyCmd() #432
Merged
feat: add copyCmd() #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
binbin-li
reviewed
Jul 1, 2022
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
qweeah
requested changes
Jul 1, 2022
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
qweeah
requested changes
Jul 4, 2022
cmd/oras/copy.go
Outdated
| src, | ||
| srcRef.ReferenceOrDefault(), | ||
| dst, | ||
| dstRef.ReferenceOrDefault(), |
There was a problem hiding this comment.
@shizhMSFT For the copy src and dest, should we disable auto-filling the latest tag?
There was a problem hiding this comment.
@CharingJC Please implement according to #439
cmd/oras/copy.go
Outdated
| srcRef.ReferenceOrDefault(), | ||
| dst, | ||
| dstRef.ReferenceOrDefault(), | ||
| oras.DefaultExtendedCopyOptions, |
There was a problem hiding this comment.
We need to add more detailed status tracking via setting the copy options. Please clarify the format and implement referring to push command
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
…funcs Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
…ate func description; feat: update copyCmd help info; feat: put copy & extendCopy func params into one line Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
binbin-li
reviewed
Jul 6, 2022
cmd/oras/copy.go
Outdated
| dstRef.ReferenceOrDefault(), | ||
| oras.DefaultCopyOptions, | ||
| ) | ||
| desc, err = oras.Copy(ctx, src, srcRef.ReferenceOrDefault(), dst, dstRef.ReferenceOrDefault(), oras.DefaultCopyOptions) |
There was a problem hiding this comment.
Not a strong opinion, I'd like to create a struct wrapping up related params instead of passing too many params directly.
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
This was referenced Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #307
Signed-off-by: Juncheng Zhu junczhu@microsoft.com