Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for windows-arm64 #457

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Adding support for windows-arm64 #457

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cd2a8a
Adding support for windows-arm64
koushdey Jul 22, 2022
131736b
Fixing failures in makefile
koushdey Jul 28, 2022
5f4fd34
Addressed review comments
koushdey Aug 1, 2022
4cd116c
format Makefile with newlines
shizhMSFT Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,18 @@ build-mac-arm64:
-o bin/darwin/arm64/$(CLI_EXE) $(CLI_PKG)

.PHONY: build-windows
build-windows:
build-windows: build-windows-amd64 build-windows-arm64

.PHONY: build-windows-amd64
build-windows-amd64:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A empty line is required between makefile items for consistency and readability.

For example:

a:
    Build a

b:
    Build b

c:
    Build c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked if modified target can be made, it's better to add empty line between items.

GOARCH=amd64 CGO_ENABLED=0 GOOS=windows go build -v --ldflags="$(LDFLAGS)" \
-o bin/windows/amd64/$(CLI_EXE).exe $(CLI_PKG)

.PHONY: build-windows-arm64
build-windows-arm64:
GOARCH=arm64 CGO_ENABLED=0 GOOS=windows go build -v --ldflags="$(LDFLAGS)" \
-o bin/windows/arm64/$(CLI_EXE).exe $(CLI_PKG)

.PHONY: check-encoding
check-encoding:
! find cmd internal -name "*.go" -type f -exec file "{}" ";" | grep CRLF
Expand Down