feat: support push a blob to a remote registry #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mark the command |
qweeah
requested changes
Aug 11, 2022
m5i-work
reviewed
Aug 11, 2022
yuehaoliang
reviewed
Aug 11, 2022
yuehaoliang
reviewed
Aug 11, 2022
qweeah
reviewed
Aug 11, 2022
qweeah
reviewed
Aug 12, 2022
lizMSFT
force-pushed
the
liz/476
branch
4 times, most recently
from
377b2e1
to
5e0ae90
Compare
qweeah
requested changes
Aug 15, 2022
lizMSFT
force-pushed
the
liz/476
branch
4 times, most recently
from
1601d0e
to
05040c7
Compare
qweeah
reviewed
Aug 23, 2022
qweeah
requested changes
Aug 23, 2022
qweeah
reviewed
Aug 24, 2022
qweeah
reviewed
Aug 24, 2022
qweeah
requested changes
Aug 26, 2022
qweeah
requested changes
Aug 29, 2022
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Wwwsylvia
reviewed
Sep 8, 2022
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
shizhMSFT
requested changes
Sep 9, 2022
| } | ||
|
|
||
| cmd.Flags().Int64VarP(&opts.size, "size", "", 0, "provide the blob size") | ||
| cmd.Flags().StringVarP(&opts.mediaType, "media-type", "", ocispec.MediaTypeImageLayer, "specify the returned media type in the descriptor if `--descriptor` is used") |
There was a problem hiding this comment.
@FeynmanZhou @yizha1 What's the default media type for blobs? Currently, it is ocispec.MediaTypeImageLayer, which is consistent with oras push. We need to review it later.
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
shizhMSFT
requested changes
Sep 9, 2022
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
yuehaoliang
reviewed
Sep 13, 2022
internal/file/file.go
Outdated
| // prepares the content descriptor from stdin | ||
| if path == "-" { | ||
| // throw err if size or digest is not provided. | ||
| if size < 0 || dgst == "" { |
There was a problem hiding this comment.
I understand that pushing a manifest doesn't require users to input its digest and size, because manifest has a small size and can be loaded into memory.
Preparing the content of the manifest can share the same part of reading from the file and generate the descriptor. After an offline discussion, I'll try to write a separate PrepareManifestContent() with unit tests.
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command to push a blob to a remote registry
Resolves: #476
Signed-off-by: Zoey Li zoeyli@microsoft.com