fix: add empty check on blobs and manifest annotation #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qweeah
requested changes
Aug 11, 2022
qweeah
reviewed
Aug 11, 2022
qweeah
requested changes
Aug 12, 2022
qweeah
requested changes
Aug 12, 2022
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
jasminetMSFT
force-pushed
the
jasmine/467
branch
from
026c315
to
24987b6
Compare
shizhMSFT
reviewed
Aug 15, 2022
cmd/oras/internal/option/pusher.go
Outdated
Comment on lines
31
to
32
| annotationConfig = "$config" | ||
| annotationManifest = "$manifest" |
There was a problem hiding this comment.
Let's make them public and update the references in cmd/oras/push.go.
cmd/oras/internal/option/pusher.go
Outdated
Comment on lines
77
to
83
| // ValidateEmpty checks whether blobs or manifest annotation are empty. | ||
| func (opts *Pusher) ValidateEmpty(args []string) error { | ||
| if len(args) == 1 && opts.ManifestAnnotations == "" { | ||
| return errors.New("no blob and manifest annotation are provided") | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This logic is attach specific. You might want to take it out of the Pusher option.
jasminetMSFT
force-pushed
the
jasmine/467
branch
from
24987b6
to
147d7a0
Compare
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
jasminetMSFT
force-pushed
the
jasmine/467
branch
from
147d7a0
to
9d067fc
Compare
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
=======================================
Coverage 71.90% 71.90%
=======================================
Files 9 9
Lines 388 388
=======================================
Hits 279 279
Misses 87 87
Partials 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shizhMSFT
reviewed
Aug 17, 2022
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #467
Signed-off-by: JasmineTang jasminetang@microsoft.com