Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print post-copy logs for unnamed content in verbose mode #511

Merged
merged 2 commits into from
Aug 19, 2022
Merged

fix: print post-copy logs for unnamed content in verbose mode #511

merged 2 commits into from
Aug 19, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

The verbose flag should work properly when unnamed content is skipped or downloaded. It currently does not. Example: this "downloading" is not paired with a "downloaded".

Screen Shot 2022-08-19 at 12 02 50

Part of issue #415

Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #511 (6cc615b) into main (8bd2dc2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage   72.68%   72.68%           
=======================================
  Files           9        9           
  Lines         388      388           
=======================================
  Hits          282      282           
  Misses         85       85           
  Partials       21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cmd/oras/pull.go Outdated Show resolved Hide resolved
…ipped or downloaded

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
Copy link
Contributor Author

After the fix, the verbose flag works properly.

Screen Shot 2022-08-19 at 16 01 32

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah
Copy link
Contributor

qweeah commented Aug 19, 2022

BTW, the title of this PR should be

fix: print post-copy logs for unnamed content in verbose mode

@wangxiaoxuan273 wangxiaoxuan273 changed the title fix: the verbose flag should work properly with unnamed content fix: print post-copy logs for unnamed content in verbose mode Aug 19, 2022
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 75d03fe into oras-project:main Aug 19, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the verbose-fix branch August 19, 2022 10:25
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
…roject#511)

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants