Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change to use repo instead of repo.manifest because it needs to fetch a blob #637

Merged
merged 9 commits into from
Oct 10, 2022

Conversation

yuehaoliang
Copy link
Contributor

Resolve #636

Signed-off-by: Haoliang Yue yuehaoliang@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #637 (67687d3) into main (cc40e43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #637   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          14       14           
  Lines         513      513           
=======================================
  Hits          370      370           
  Misses        114      114           
  Partials       29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 4cbc6e4 into oras-project:main Oct 10, 2022
qweeah pushed a commit to qweeah/oras that referenced this pull request Oct 11, 2022
…fetch a blob (oras-project#637)

Resolve oras-project#636 

Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
qweeah pushed a commit to qweeah/oras that referenced this pull request Oct 13, 2022
…fetch a blob (oras-project#637)

Resolve oras-project#636 

Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Oct 13, 2022
…fetch a blob (#637)

Resolve #636 

Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
…fetch a blob (oras-project#637)

Resolve oras-project#636 

Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: manifest fetch fails when confirming the platform of a manifest
3 participants