Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: alias remove to delete and rename confirmation flag to force #677

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 7, 2022

Resolves #667

@codecov-commenter
Copy link

Codecov Report

Merging #677 (c35ef04) into main (690716b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          14       14           
  Lines         513      513           
=======================================
  Hits          370      370           
  Misses        114      114           
  Partials       29       29           
Impacted Files Coverage Δ
cmd/oras/internal/option/confirmation.go 85.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah qweeah changed the title feat!: alias remove to delete feat!: alias remove to delete and rename confirmation flag to force Nov 7, 2022
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@shizhMSFT shizhMSFT merged commit 9391f7b into oras-project:main Nov 7, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
…rce` (oras-project#677)

Resolves oras-project#667

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use shorter commands by default
3 participants