feat(oci-layout): support in oras push and oras attach
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 63.96% 64.14% +0.18%
==========================================
Files 19 19
Lines 702 700 -2
==========================================
Hits 449 449
+ Misses 222 220 -2
Partials 31 31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
changed the title
oras push and oras attachoras push and oras attach
FeynmanZhou
reviewed
Jan 17, 2023
Wwwsylvia
reviewed
Jan 17, 2023
shizhMSFT
reviewed
Jan 17, 2023
Comment on lines
+171
to
+178
| // Reassemble a reference with subject digest | ||
| if repo, ok := dst.(*remote.Repository); ok { | ||
| ref := repo.Reference | ||
| ref.Reference = subject.Digest.String() | ||
| opts.RawReference = ref.String() | ||
| } else if opts.Type == option.TargetTypeOCILayout { | ||
| opts.RawReference = fmt.Sprintf("%s@%s", opts.Path, subject.Digest) | ||
| } |
There was a problem hiding this comment.
We can just do switch opts.Type.
There was a problem hiding this comment.
But repo.Reference (including Host name and repository name) need *remote.Repository type assertion anyway.
| oerrors "oras.land/oras/cmd/oras/internal/errors" | ||
| "oras.land/oras/cmd/oras/internal/option" | ||
| ) | ||
|
|
||
| type attachOptions struct { | ||
| option.Common | ||
| option.Remote | ||
| option.Packer | ||
| option.ImageSpec | ||
| option.DistributionSpec |
There was a problem hiding this comment.
I just noticed that the DistributionSpec should be stick to the option.Remote. This should also be applied to oras cp and oras manifest push.
There was a problem hiding this comment.
No it should not. If we do that, DistributionSpec will be applied to all commands related to option.Remote, which is wrong considering the following cases:
- Since
oras pushis not related to referrers maintanance, the execution is always the same no matter what value is provided to--distribution-spec. So we should NEVER apply this flag tooras push. Same for other commands. - If user specify
--distribution-spec v1.1-referrers-tagtooras discover, should the command looking for referrers via tag scheme? We should design the expected behaviour and then add this flag to those commands. Before that,--distribution-specshould not be applied tooras discover.
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
…ect#750) Related to oras-project#378 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #378