Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: disable auto type conversion for manifests #797

Merged
merged 15 commits into from
Mar 6, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Feb 10, 2023

This PR changes the default media type of oras push and oras attach by removing the auto-conversion of the manifest type.

Resolves #782

Signed-off-by: Billy Zha jinzha1@microsoft.com

@qweeah qweeah marked this pull request as ready for review February 10, 2023 08:48
@qweeah qweeah marked this pull request as draft February 10, 2023 08:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #797 (fb745f5) into main (12431d5) will increase coverage by 0.15%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   66.24%   66.39%   +0.15%     
==========================================
  Files          21       21              
  Lines         862      860       -2     
==========================================
  Hits          571      571              
+ Misses        245      243       -2     
  Partials       46       46              
Impacted Files Coverage Δ
cmd/oras/internal/option/spec.go 18.51% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah qweeah marked this pull request as ready for review February 28, 2023 02:26
cmd/oras/attach.go Outdated Show resolved Hide resolved
cmd/oras/attach.go Outdated Show resolved Hide resolved
cmd/oras/attach.go Outdated Show resolved Hide resolved
qweeah added 13 commits March 6, 2023 10:00
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 16e40b5 into oras-project:main Mar 6, 2023
qweeah added a commit to qweeah/oras that referenced this pull request Mar 6, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable auto conversion of manifest types
4 participants