Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability query tags for oras repo tags command #800

Merged
merged 8 commits into from
Feb 23, 2023
Merged

feat: Add ability query tags for oras repo tags command #800

merged 8 commits into from
Feb 23, 2023

Conversation

TerryHowe
Copy link
Member

@TerryHowe TerryHowe commented Feb 10, 2023 •
edited
Loading

Add a ability for the oras repo tags command to get the tags associated with a specified digest or tag. Given a tag, it will return the digest. Given a digest, it will return the tag.

Closes: #799

Signed-off-by: Terry Howe tlhowe@amazon.com

@TerryHowe TerryHowe marked this pull request as draft February 10, 2023 21:50
@TerryHowe TerryHowe changed the title feat: Add filter option to oras repo tags command feat: Add ability query tags for oras repo tags command Feb 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023 •
edited
Loading

Codecov Report

Merging #800 (c3a8e4a) into main (4d97bbd) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   63.50%   63.50%           
=======================================
  Files          21       21           
  Lines         844      844           
=======================================
  Hits          536      536           
  Misses        265      265           
  Partials       43       43

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TerryHowe TerryHowe marked this pull request as ready for review February 11, 2023 13:52
@qweeah
Copy link
Contributor

qweeah commented Feb 13, 2023

Given a tag, it will return the digest.

This is an inconsistent user experience since the return value is not tags any more. Functionally it's already covered by oras manifest get. I think it's better to return error.

qweeah
qweeah reviewed Feb 13, 2023
View reviewed changes
cmd/oras/repository/tags.go Outdated Show resolved Hide resolved
qweeah
qweeah reviewed Feb 13, 2023
View reviewed changes
cmd/oras/repository/tags.go Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT mentioned this pull request Feb 15, 2023
Closed
1 task
@TerryHowe TerryHowe mentioned this pull request Feb 15, 2023
Closed
@TerryHowe TerryHowe mentioned this pull request Feb 19, 2023
Open
qweeah
qweeah reviewed Feb 20, 2023
View reviewed changes
cmd/oras/repository/tags.go Outdated Show resolved Hide resolved
qweeah
qweeah reviewed Feb 20, 2023
View reviewed changes
cmd/oras/repository/tags.go Outdated Show resolved Hide resolved
qweeah
qweeah approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions. Also, I have added test enhancement in #829. Feel free to comment if you are interested in adding them, or you come up with any new cases.

@qweeah
Copy link
Contributor

qweeah commented Feb 21, 2023

@TerryHowe Can you help rebase the PR? @shizhMSFT Please take a look when you have time, thanks.

shizhMSFT
shizhMSFT reviewed Feb 21, 2023
View reviewed changes
cmd/oras/repository/tags.go Outdated Show resolved Hide resolved
cmd/oras/repository/tags.go Outdated Show resolved Hide resolved
@shizhMSFT
Copy link
Contributor

@TerryHowe The PR overall LGTM but I left some comments on the user experience.

Terry Howe added 6 commits February 22, 2023 08:18
feat: Add filter option to oras repo tags command
e06d9d0 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Add support for tags in reference
1a328c1 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Address digest comments
f5a37e7 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Add usage examples
541303f 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Add warning print
f74bd0b 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Use full sha
042fb39 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Terry Howe added 2 commits February 22, 2023 08:18
Use logger instead of fprintln
822fb55 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Print requested reference tag
687b324 
Signed-off-by: Terry Howe <tlhowe@amazon.com>
qweeah
qweeah approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 0a34492 into oras-project:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@qweeah qweeah qweeah approved these changes

@deitch deitch Awaiting requested review from deitch

@jdolitsky jdolitsky Awaiting requested review from jdolitsky

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter to oras repo tags to filter by sha or tag
4 participants
@TerryHowe @codecov-commenter @qweeah @shizhMSFT