fix: Improve error message on oras copy.go with non-existent tags #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanjasir90
requested review from
deitch,
jdolitsky,
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
|
@shizhMSFT @qweeah could u pls review it! |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 66.89% 66.89%
=======================================
Files 21 21
Lines 879 879
=======================================
Hits 588 588
Misses 245 245
Partials 46 46 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qweeah
requested changes
Mar 3, 2023
shizhMSFT
requested changes
Mar 3, 2023
|
@qweeah and @shizhMSFT I have made necessary give changes :) |
Signed-off-by: khanjasir90 <khanmohdjasir@gmail.com>
Signed-off-by: khanjasir90 <khanmohdjasir@gmail.com>
shizhMSFT
force-pushed
the
khanjasir90/improve-error-message-with-non-existent-tags
branch
from
110fa73
to
f1c568d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improves Error message on oras copy.go with non-existent tags
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #791
Please check the following list: