Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: improve debug log readability #861

Merged
merged 5 commits into from
Mar 9, 2023
Merged

feat!: improve debug log readability #861

merged 5 commits into from
Mar 9, 2023

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Mar 7, 2023

Resolves #851

Current UX:
image

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #861 (2bd1ad5) into main (03bc2b2) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #861   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files          21       21           
  Lines         860      860           
=======================================
  Hits          571      571           
  Misses        243      243           
  Partials       46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah qweeah changed the title debug: improve debug log readability feat: improve debug log readability Mar 7, 2023
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@qweeah qweeah changed the title feat: improve debug log readability feat!: improve debug log readability Mar 7, 2023
qweeah
qweeah previously requested changes Mar 7, 2023
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
internal/trace/transport.go Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT requested a review from qweeah March 9, 2023 05:17
@shizhMSFT shizhMSFT dismissed qweeah’s stale review March 9, 2023 05:18

Discussed offline with Billy and related conversations are resolved.

@shizhMSFT shizhMSFT merged commit 11e6947 into oras-project:main Mar 9, 2023
@wangxiaoxuan273 wangxiaoxuan273 deleted the debugo branch March 9, 2023 05:18
@qweeah qweeah mentioned this pull request Mar 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve readability of registry debug logs
5 participants