Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for manifest fetch-config under oci-layout #889

Merged
merged 3 commits into from
Mar 16, 2023
Merged

test: add e2e tests for manifest fetch-config under oci-layout #889

merged 3 commits into from
Mar 16, 2023

Conversation

wangxiaoxuan273
Copy link
Contributor

Resolves #864

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help also add spec covering below bad paths:

  • should fail fetching manifest config from registry without any tag or digest provided
  • should fail fetching manifest config from layout without any tag or digest provided
  • should fail fetching manifest from registry without any tag or digest provided
  • should fail fetching manifest from layout without any tag or digest provided

test/e2e/suite/command/manifest.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #889 (402ea6b) into main (54eb25a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files          21       21           
  Lines         860      860           
=======================================
  Hits          571      571           
  Misses        243      243           
  Partials       46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit a55201b into oras-project:main Mar 16, 2023
@wangxiaoxuan273 wangxiaoxuan273 deleted the manifest-fetch-config-e2e branch March 16, 2023 05:43
@qweeah qweeah mentioned this pull request Mar 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add OCI image layout e2e test specs for oras manifest fetch-config
3 participants